Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update record_bag action #112

Merged
merged 35 commits into from
Jul 17, 2024
Merged

update record_bag action #112

merged 35 commits into from
Jul 17, 2024

Conversation

fred-labs
Copy link
Contributor

@fred-labs fred-labs commented Jul 15, 2024 •
edited
Loading

Description

  • Action record_bag: allow capturing in sim_time
  • add gazebo_static_camera to place a fixed camera for monitoring
  • example-multi-robot
    • replace second turtlebot with basic robot
    • add ros bag recording

Pull request checklist

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • Format and Lint checks (make check) pass locally
  • PR applies Apache 2.0 License to all code files

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe)

Current behavior

New behavior

How to test

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

Test Results

236 tests   222 ✅  25m 24s ⏱️
 14 suites   14 💤
 14 files      0 ❌

Results for commit 67cda2f.

♻️ This comment has been updated with latest results.

@fred-labs fred-labs marked this pull request as ready for review July 16, 2024 08:55
@fred-labs fred-labs requested a review from fmirus July 17, 2024 07:33
@fred-labs fred-labs enabled auto-merge (squash) July 17, 2024 07:43
@fred-labs fred-labs merged commit b3c03a0 into main Jul 17, 2024
24 checks passed
@fred-labs fred-labs deleted the ci_rosbag branch July 17, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmirus fmirus fmirus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fred-labs @fmirus